Skip to content

[GHSA-gv83-gqw6-9j2c] Name the affected module github.com/gofiber/fiber/v3 - #11036

Open
jamesconwaydev wants to merge 1 commit into
github:jamesconwaydev/advisory-improvement-11036from
jamesconwaydev:GHSA-gv83-gqw6-9j2c-module-path
Open

jamesconwaydev wants to merge 1 commit into
github:jamesconwaydev/advisory-improvement-11036from
jamesconwaydev:GHSA-gv83-gqw6-9j2c-module-path

Conversation

@jamesconwaydev

Copy link
Copy Markdown

At the moment this record names github.com/gofiber/fiber, with a fix in 3.4.0. That module path doesn't exist at v3, so a scanner looking at github.com/gofiber/fiber/v3 won't match it. This PR changes the package to github.com/gofiber/fiber/v3 and adds the fix PR and commit as references.

Evidence:

  • The Go module proxy refuses the unversioned path at that version: proxy.golang.org/github.com/gofiber/fiber/@v/v3.4.0.info says invalid version: go.mod has post-v3 module path "github.com/gofiber/fiber/v3" at revision v3.4.0. .../fiber/v3/@v/v3.4.0.info resolves.
  • The fix is gofiber/fiber#4389 ("Use Scheme() for HTTPS detection..."), merged as 04dd4e7. That commit is in v3.4.0 and not in v3.3.0 (compare).
  • v2 isn't affected. Both lines' helmet middleware checks c.Protocol() == "https". In v2.52.9, Ctx.Protocol() returns the scheme. In v3.3.0, DefaultReq.Protocol() returns the request's HTTP version, such as HTTP/1.1, so the check never matched. That's why this advisory is about v3 only.
  • The range is unchanged: introduced: 0 and fixed: 3.4.0.

Disclosure: I prepared this with Claude Code (an AI assistant), then checked every source above myself.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The review identifies no active issues, with the advisory’s module path corrected and upstream fix references added while preserving its existing version range and metadata.

No open issues 🎉

What changed in this PR

Updates the GoFiber security advisory to identify the correct v3 module path and include references to the upstream fix.

Changes:

  • Changes the affected package to github.com/gofiber/fiber/v3.
  • Adds references to the fixing pull request and commit.
  • Preserves the existing affected-version range and advisory metadata.
File Description
advisories/​github-reviewed/​2026/​07/​GHSA-gv83-gqw6-9j2c/​GHSA-gv83-gqw6-9j2c.json Corrects the Go module path and adds remediation references.

Review effort: Lite (auto)

@github-actions
github-actions Bot changed the base branch from main to jamesconwaydev/advisory-improvement-11036 November 9, 2026 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants